When default @SwiftName rules are being applied, this update changes the Swift names of inner Java interfaces and of types declared within Java interfaces. Previously, if an interface Bar was declared within a type Foo or a concrete type Bar was declared within an interface Foo, they would be translated to a top-level type with Swift name Bar. This could cause problems if another inner type with the same name was also promoted. Now the Swift type name in each of these cases will be formed by concatenating the outer and inner type names: FooBar. This matches KMP's Swift naming of inner interfaces and of concrete types within interfaces. - #2831
Open
copybara-service[bot] wants to merge 1 commit into
Open
When default @SwiftName rules are being applied, this update changes the Swift names of inner Java interfaces and of types declared within Java interfaces. Previously, if an interface Bar was declared within a type Foo or a concrete type Bar was declared within an interface Foo, they would be translated to a top-level type with Swift name Bar. This could cause problems if another inner type with the same name was also promoted. Now the Swift type name in each of these cases will be formed by concatenating the outer and inner type names: FooBar. This matches KMP's Swift naming of inner interfaces and of concrete types within interfaces.#2831copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_964107865
branch
5 times, most recently
from
August 20, 2026 04:28
16199b9 to
249a96a
Compare
copybara-service
Bot
changed the title
…the Swift names of inner Java interfaces and of types declared within Java interfaces. Previously, if an interface Bar was declared within a type Foo or a concrete type Bar was declared within an interface Foo, they would be translated to a top-level type with Swift name Bar. This could cause problems if another inner type with the same name was also promoted. Now the Swift type name in each of these cases will be formed by concatenating the outer and inner type names: FooBar. This matches KMP's Swift naming of inner interfaces and of concrete types within interfaces. PiperOrigin-RevId: 964107865
copybara-service
Bot
force-pushed
the
test_964107865
branch
from
August 20, 2026 05:17
249a96a to
5f37181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When default @SwiftName rules are being applied, this update changes the Swift names of inner Java interfaces and of types declared within Java interfaces. Previously, if an interface Bar was declared within a type Foo or a concrete type Bar was declared within an interface Foo, they would be translated to a top-level type with Swift name Bar. This could cause problems if another inner type with the same name was also promoted. Now the Swift type name in each of these cases will be formed by concatenating the outer and inner type names: FooBar. This matches KMP's Swift naming of inner interfaces and of concrete types within interfaces.